http://gwt-code-reviews.appspot.com/1301801/diff/1/4
File user/src/com/google/gwt/user/client/ui/HeaderPanel.java (right):

http://gwt-code-reviews.appspot.com/1301801/diff/1/4#newcode37
user/src/com/google/gwt/user/client/ui/HeaderPanel.java:37:
Rendering bug: vertical scrollbars will be hidden in the header and
footer widgets.

http://gwt-code-reviews.appspot.com/1301801/diff/1/4#newcode135
user/src/com/google/gwt/user/client/ui/HeaderPanel.java:135: public
Iterator<Widget> iterator() {
It seems odd to have an iterator over a 3-element panel. Why is it
useful?

Also, JavaDoc.

http://gwt-code-reviews.appspot.com/1301801/diff/1/4#newcode346
user/src/com/google/gwt/user/client/ui/HeaderPanel.java:346: int
remainingHeight = getOffsetHeight();
Should this be getElement().getClientHeight() instead of
getOffsetHeight() so that borders/padding don't cause the middle element
to overlap the footer panel?

http://gwt-code-reviews.appspot.com/1301801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to