LGTM

http://gwt-code-reviews.appspot.com/1301801/diff/5001/6001
File user/src/com/google/gwt/user/ResizeLayoutPanel.gwt.xml (right):

http://gwt-code-reviews.appspot.com/1301801/diff/5001/6001#newcode23
user/src/com/google/gwt/user/ResizeLayoutPanel.gwt.xml:23: <!-- Most
browsers do not support onresize. -->
Instead of explicitly listing out the browsers that do not support
onresize, can you provide a default and override that default for
IE/IE6? For example:
http://gwt-code-reviews.appspot.com/1296801/patch/8006/39001

http://gwt-code-reviews.appspot.com/1301801/diff/5001/6003
File user/src/com/google/gwt/user/client/ui/HeaderPanel.java (right):

http://gwt-code-reviews.appspot.com/1301801/diff/5001/6003#newcode42
user/src/com/google/gwt/user/client/ui/HeaderPanel.java:42: private
final ResizeLayoutPanel.Impl footerImpl =
GWT.create(ResizeLayoutPanel.Impl.class);
80 chars

http://gwt-code-reviews.appspot.com/1301801/diff/5001/6003#newcode45
user/src/com/google/gwt/user/client/ui/HeaderPanel.java:45: private
final ResizeLayoutPanel.Impl headerImpl =
GWT.create(ResizeLayoutPanel.Impl.class);
80 chars

http://gwt-code-reviews.appspot.com/1301801/diff/5001/6007
File user/test/com/google/gwt/user/client/ui/ResizeLayoutPanelTest.java
(right):

http://gwt-code-reviews.appspot.com/1301801/diff/5001/6007#newcode292
user/test/com/google/gwt/user/client/ui/ResizeLayoutPanelTest.java:292:
handler.assertResizeFired(false);
Is the second call to assertResizeFired() useful?

http://gwt-code-reviews.appspot.com/1301801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to