http://gwt-code-reviews.appspot.com/1311802/diff/1/2
File plugins/config.mk (left):

http://gwt-code-reviews.appspot.com/1311802/diff/1/2#oldcode75
plugins/config.mk:75: OMARCH=i386
OMARCH wasn't being used anywhere.

http://gwt-code-reviews.appspot.com/1311802/diff/1/3
File plugins/xpcom/Makefile (left):

http://gwt-code-reviews.appspot.com/1311802/diff/1/3#oldcode136
plugins/xpcom/Makefile:136: -L$(DEFAULT_FIREFOX_LIBS) \
why we were trying to link against the host install of firefox is a
mystery to
me. Everything we need is in the GECKO_LIBS.

http://gwt-code-reviews.appspot.com/1311802/diff/1/3
File plugins/xpcom/Makefile (right):

http://gwt-code-reviews.appspot.com/1311802/diff/1/3#newcode99
plugins/xpcom/Makefile:99: MOZJS_DLLFLAGS = -lxul
The JS symbols can now be found in libxul. We had been getting lucky due
to the
way the linkage was setup on linux. See the gecko-2.0.0 Darwin README
for the
gory details of getting this correct on Darwin.

http://gwt-code-reviews.appspot.com/1311802/diff/1/3#newcode222
plugins/xpcom/Makefile:222: $(CXX) -o $@ $(FF_OBJS) $(COMMON)
$(DLLFLAGS)
-m$(FLAGBIT) comes through in the DLLFLAGS for linux, but setting it is
wrong
for OSX since we want a universal bundle.

http://gwt-code-reviews.appspot.com/1311802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to