LGTM
http://gwt-code-reviews.appspot.com/1311802/diff/1/2 File plugins/config.mk (right): http://gwt-code-reviews.appspot.com/1311802/diff/1/2#newcode85 plugins/config.mk:85: ALLARCHCFLAGS=-arch i386 -arch ppc -arch x86_64 So we will build with all 3 architectures? I thought PPC was being phased out, so we would have x86/x86_64 instead of x86/ppc? http://gwt-code-reviews.appspot.com/1311802/diff/1/3 File plugins/xpcom/Makefile (left): http://gwt-code-reviews.appspot.com/1311802/diff/1/3#oldcode136 plugins/xpcom/Makefile:136: -L$(DEFAULT_FIREFOX_LIBS) \ On 2011/01/20 21:39:11, conroy wrote:
why we were trying to link against the host install of firefox is a
mystery to
me. Everything we need is in the GECKO_LIBS.
This made it easier for people to build on their own distro by just installing the right devel packages without having to set it up like gecko-sdk. However, I am not opposed to removing it, especially since paths vary so much between distros anyway. http://gwt-code-reviews.appspot.com/1311802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
