Few nits about the styles: button image is off by 1px in showcase button
example, and a few blue border elements remain.


http://gwt-code-reviews.appspot.com/1330801/diff/1/8
File
user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome.css
(right):

http://gwt-code-reviews.appspot.com/1330801/diff/1/8#newcode233
user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome.css:233:
line-height: 0px;
This seems like a breaking change. Why not just put it in clean.css to
avoid breaking existing implementations? (Here, below, in
chrome_rtl.css, standards*.css, and dark*.css)

http://gwt-code-reviews.appspot.com/1330801/diff/1/13
File user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css
(right):

http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode52
user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:52:
Nit: Be consistent in newlines after }'s.

http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode549
user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:549:
filter: alpha(opacity=40);
Why not opacity=50, since the standards version is .5?

http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode573
user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:573:
filter: alpha(opacity=40);
Why not opacity=50, since the standards version is .5?

http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode1044
user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:1044:
filter: alpha(opacity=40);
Why not opacity=50, since the standards version is .5?

http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode1123
user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:1123:
background: url(images/hborder2.png) repeat-x 0px -30px;;
extra ; at the end.

http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode1148
user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:1148:
background: url(images/hborder2.png) repeat-x 0px -30px;;
extra ; at the end.

http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode1158
user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:1158:
vertical-align: center;
"center" isn't valid for vertical-align, did you mean "middle"?

http://gwt-code-reviews.appspot.com/1330801/diff/1/14
File
user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css
(right):

http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode549
user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:549:
filter: alpha(opacity=40);
Why not opacity=50, since the standards version is .5?

http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode573
user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:573:
filter: alpha(opacity=40);
Why not opacity=50, since the standards version is .5?

http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1018
user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1018:
filter: alpha(opacity=40);
Why not opacity=50, since the standards version is .5?

http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1044
user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1044:
filter: alpha(opacity=40);
Why not opacity=50, since the standards version is .5?

http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1124
user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1124:
background: url(images/hborder2.png) repeat-x 0px -30px;;
Extra ;

http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1149
user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1149:
background: url(images/hborder2.png) repeat-x 0px -30px;;
Extra ;

http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1159
user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1159:
vertical-align: center;
"center" isn't valid for vertical-align, did you mean "middle"?

http://gwt-code-reviews.appspot.com/1330801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to