http://gwt-code-reviews.appspot.com/1330801/diff/1/8 File user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome.css (right):
http://gwt-code-reviews.appspot.com/1330801/diff/1/8#newcode233 user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome.css:233: line-height: 0px; This is fixing an existing bug in VerticalSplitPanel where the splitter to too tall. I added it to HorizontalSplitPanel for consistency and in case the panel is very small. Since you can't put text in the splitter, its very unlikely to break anyone. You can see the bug here: http://gwt.google.com/samples/Showcase/Showcase.html#!CwVerticalSplitPanel http://gwt-code-reviews.appspot.com/1330801/diff/1/13 File user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css (right): http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode52 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:52: I think we are. Line breaks are used between widgets, but not between styles that apply to the same widget. http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode549 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:549: filter: alpha(opacity=40); There are subtle differences in the way IE renders opacity versus other browsers. Using slightly different numbers makes the buttons look more similar. I switched to use 45 in IE, which looks closer to .5 in other browsers. http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode573 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:573: filter: alpha(opacity=40); see above http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode1044 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:1044: filter: alpha(opacity=40); see above http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode1148 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:1148: background: url(images/hborder2.png) repeat-x 0px -30px;; On 2011/01/27 14:35:27, pdr wrote:
extra ; at the end.
Done. http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode1158 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:1158: vertical-align: center; On 2011/01/27 14:35:27, pdr wrote:
"center" isn't valid for vertical-align, did you mean "middle"?
Done. http://gwt-code-reviews.appspot.com/1330801/diff/1/14 File user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css (right): http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode549 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:549: filter: alpha(opacity=40); see comment in clean.css http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode573 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:573: filter: alpha(opacity=40); see comment in clean.css http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1018 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1018: filter: alpha(opacity=40); see comment in clean.css http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1044 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1044: filter: alpha(opacity=40); see comment in clean.css http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1124 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1124: background: url(images/hborder2.png) repeat-x 0px -30px;; On 2011/01/27 14:35:27, pdr wrote:
Extra ;
Done. http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1149 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1149: background: url(images/hborder2.png) repeat-x 0px -30px;; On 2011/01/27 14:35:27, pdr wrote:
Extra ;
Done. http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1159 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1159: vertical-align: center; On 2011/01/27 14:35:27, pdr wrote:
"center" isn't valid for vertical-align, did you mean "middle"?
Done. http://gwt-code-reviews.appspot.com/1330801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
