http://gwt-code-reviews.appspot.com/1340802/diff/1/2 File user/src/com/google/gwt/editor/client/EditorContext.java (right):
http://gwt-code-reviews.appspot.com/1340802/diff/1/2#newcode114 user/src/com/google/gwt/editor/client/EditorContext.java:114: * Traverse a editor created by an editor http://gwt-code-reviews.appspot.com/1340802/diff/1/8 File user/src/com/google/gwt/editor/client/impl/AbstractEditorDelegate.java (right): http://gwt-code-reviews.appspot.com/1340802/diff/1/8#newcode57 user/src/com/google/gwt/editor/client/impl/AbstractEditorDelegate.java:57: Chain(CompositeEditor<T, R, S> composedEditor, Class<R> composedElementType) { line too long http://gwt-code-reviews.appspot.com/1340802/diff/1/8#newcode118 user/src/com/google/gwt/editor/client/impl/AbstractEditorDelegate.java:118: public <R, S extends Editor<R>> void createChain(Class<R> composedElementType) { Should this be protected? http://gwt-code-reviews.appspot.com/1340802/diff/1/15 File user/src/com/google/gwt/editor/client/impl/Initializer.java (right): http://gwt-code-reviews.appspot.com/1340802/diff/1/15#newcode35 user/src/com/google/gwt/editor/client/impl/Initializer.java:35: // Tell the EditorDelegate about the object its responsible for it's http://gwt-code-reviews.appspot.com/1340802/diff/1/15#newcode42 user/src/com/google/gwt/editor/client/impl/Initializer.java:42: HasEditorDelegate<Q> asDelegate = ctx.asHasEditorDelegate(); asHasDelegate http://gwt-code-reviews.appspot.com/1340802/diff/1/16 File user/src/com/google/gwt/editor/client/impl/Refresher.java (right): http://gwt-code-reviews.appspot.com/1340802/diff/1/16#newcode25 user/src/com/google/gwt/editor/client/impl/Refresher.java:25: * the editor and delegate hiererchy. Perhaps you could simplify initializer, and require that it be used in tandem with refresher? Or make it wrap a refresher? Get rid of some redundancy? http://gwt-code-reviews.appspot.com/1340802/diff/1/17 File user/src/com/google/gwt/editor/client/impl/RootEditorContext.java (right): http://gwt-code-reviews.appspot.com/1340802/diff/1/17#newcode42 user/src/com/google/gwt/editor/client/impl/RootEditorContext.java:42: public T checkAssignment(Object value) { Document as unsupported? http://gwt-code-reviews.appspot.com/1340802/diff/1/24 File user/src/com/google/gwt/editor/rebind/AbstractEditorDriverGenerator.java (right): http://gwt-code-reviews.appspot.com/1340802/diff/1/24#newcode44 user/src/com/google/gwt/editor/rebind/AbstractEditorDriverGenerator.java:44: public abstract class AbstractEditorDriverGenerator extends Generator { Here's the punchline, eh? Nice to see all that red in the diff. http://gwt-code-reviews.appspot.com/1340802/diff/1/29 File user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryEditorDelegate.java (right): http://gwt-code-reviews.appspot.com/1340802/diff/1/29#newcode86 user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryEditorDelegate.java:86: * Must call four-arg version instead. Are you sure you want the base initialize method to be public, then? http://gwt-code-reviews.appspot.com/1340802/diff/1/36 File user/test/com/google/gwt/editor/client/EditorErrorTest.java (right): http://gwt-code-reviews.appspot.com/1340802/diff/1/36#newcode137 user/test/com/google/gwt/editor/client/EditorErrorTest.java:137: assertEquals(errors.toString(), 2, errors.size()); That's going to be pretty cryptic when it fails http://gwt-code-reviews.appspot.com/1340802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
