http://gwt-code-reviews.appspot.com/1340802/diff/1/4 File user/src/com/google/gwt/editor/client/EditorVisitor.java (right):
http://gwt-code-reviews.appspot.com/1340802/diff/1/4#newcode27 user/src/com/google/gwt/editor/client/EditorVisitor.java:27: public <T> void endVisit(EditorContext<T> ctx) { Given that the only code that'll ever call these methods is hidden behind EditorDriver#accept, what's the purpose of the generics here? What does the <T> buys us? Why isn't it simply 'public void endVisit(EditorContext<?> ctx)' (I don't question the parameterization of EditorContext as I think it could be useful in a few (very few?) cases, e.g. after checking the getEditedType you can safely cast to some parameterization of EditorContext, instead of casting each method's return value; have I missed something?) http://gwt-code-reviews.appspot.com/1340802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
