http://gwt-code-reviews.appspot.com/1336802/diff/1/4
File dev/core/src/com/google/gwt/dev/js/JsStringInterner.java (right):

http://gwt-code-reviews.appspot.com/1336802/diff/1/4#newcode69
dev/core/src/com/google/gwt/dev/js/JsStringInterner.java:69: * Prevents
'fixing' an otherwise illegal operation.
Are these actually useful in practice?

http://gwt-code-reviews.appspot.com/1336802/diff/1/4#newcode74
dev/core/src/com/google/gwt/dev/js/JsStringInterner.java:74: ||
!(x.getArg1() instanceof JsStringLiteral);
You still need to visit the RHS. (You can do so explicitly.)

http://gwt-code-reviews.appspot.com/1336802/diff/1/4#newcode99
dev/core/src/com/google/gwt/dev/js/JsStringInterner.java:99: return
false;
Visit the RHS?

http://gwt-code-reviews.appspot.com/1336802/diff/1/4#newcode233
dev/core/src/com/google/gwt/dev/js/JsStringInterner.java:233: if
(occurences != null && occurences < 2) {
assert occurrences != null
(something is broken if it is)

http://gwt-code-reviews.appspot.com/1336802/diff/1/4#newcode362
dev/core/src/com/google/gwt/dev/js/JsStringInterner.java:362: private
static Map<String, Integer> getOccurenceMap(JsNode node) {
How about "make" or "build" since it's an expensive op?

http://gwt-code-reviews.appspot.com/1336802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to