http://gwt-code-reviews.appspot.com/1336802/diff/1/4
File dev/core/src/com/google/gwt/dev/js/JsStringInterner.java (right):

http://gwt-code-reviews.appspot.com/1336802/diff/1/4#newcode48
dev/core/src/com/google/gwt/dev/js/JsStringInterner.java:48: /**
Should this comment be changed, to indicate that it can conditionally
intern strings, based on occurrence count etc.?

http://gwt-code-reviews.appspot.com/1336802/diff/1/4#newcode93
dev/core/src/com/google/gwt/dev/js/JsStringInterner.java:93: /**
Keep comment within 80 chars?  Here and elsewhere...

http://gwt-code-reviews.appspot.com/1336802/diff/1/4#newcode102
dev/core/src/com/google/gwt/dev/js/JsStringInterner.java:102: /**
Is this the right comment here?

http://gwt-code-reviews.appspot.com/1336802/diff/1/4#newcode232
dev/core/src/com/google/gwt/dev/js/JsStringInterner.java:232: Integer
occurences = occurenceMap.get(x.getValue());
Should the number '2' be a configurable number, instead of hard-coded
here?  What's special about 2?

http://gwt-code-reviews.appspot.com/1336802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to