http://gwt-code-reviews.appspot.com/1336803/diff/1/3
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
(right):

http://gwt-code-reviews.appspot.com/1336803/diff/1/3#newcode477
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:477:
private final long zeroTimeMilliseconds;
isn't this superseded by the new TimeKeeper base?

http://gwt-code-reviews.appspot.com/1336803/diff/1/3#newcode592
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:592:
"Cummulative Collection Count",
Long.toString(gcMXBean.getCollectionCount()));
you're creating a parallel timeline here which will throw off the
speedtracer totals (speedtracer assumes a single linear timeline since
that's how the browser UI thread works)

http://gwt-code-reviews.appspot.com/1336803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to