LGTM when LGTzundel
http://gwt-code-reviews.appspot.com/1336803/diff/1/3 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/1336803/diff/1/3#newcode592 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:592: "Cummulative Collection Count", Long.toString(gcMXBean.getCollectionCount())); On 2011/02/04 15:56:46, jbrosenberg wrote:
Yeah, what I am seeing is that the summaries can't be separated for
individual
timelines that overlap...You can only get a summary for a particular
duration of
time, and overlapping timelines will all contribute. I think this is
fine and
desired behavior....The speed tracer interface doesn't currently allow
for
separating things out otherwise...You can click on individual events,
and the
total time/self-time for that event appear accurate however, so I
think it's
been good....no? Longer term, I'd have thought that making
speedtracer support
parallel timelines would be a goal anyway, no?
I don't think parallell timelines are going to be supported any time soon. One alternative approach to consider would be to annotate the top level event with its GC time. I'm fine with this going in as is if it's more useful to have this data than to have accurate summary graphs whenever timelines intersect. http://gwt-code-reviews.appspot.com/1336803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
