For some value of "now."

One change requested, and one question to John Labanca.


http://gwt-code-reviews.appspot.com/1295806/diff/1/9
File user/src/com/google/gwt/user/client/ui/HTMLPanel.java (right):

http://gwt-code-reviews.appspot.com/1295806/diff/1/9#newcode189
user/src/com/google/gwt/user/client/ui/HTMLPanel.java:189: public void
addAndReplaceElement(Widget widget, String id) {
Please overload this one too.

http://gwt-code-reviews.appspot.com/1295806/diff/1/10
File user/src/com/google/gwt/user/client/ui/HTMLTable.java (right):

http://gwt-code-reviews.appspot.com/1295806/diff/1/10#newcode1105
user/src/com/google/gwt/user/client/ui/HTMLTable.java:1105: Element td =
cleanCell(row, column, true);
@jlabanca, Should this be called in the null widget case?

http://gwt-code-reviews.appspot.com/1295806/diff/1/10#newcode1123
user/src/com/google/gwt/user/client/ui/HTMLTable.java:1123:
this.setWidget(row, column, widget.asWidget());
This one should allow nulls.

http://gwt-code-reviews.appspot.com/1295806/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to