http://gwt-code-reviews.appspot.com/1295806/diff/1/10
File user/src/com/google/gwt/user/client/ui/HTMLTable.java (right):

http://gwt-code-reviews.appspot.com/1295806/diff/1/10#newcode1105
user/src/com/google/gwt/user/client/ui/HTMLTable.java:1105: Element td =
cleanCell(row, column, true);
I guess the answer is... probably.  The question is, what should the
code below do?

table.setText(0, 0, "hello world");
table.setWidget(0, 0, null);

If you think the call to setWidget should clear the text "hello world"
(and I think that makes sense), then yes, cleanCell() should be outside
of the conditional. If you think "hello world" should remain, then no
change is needed.

Assuming we want to change it, we should add a test case.  Do you want
me to take care of it?

http://gwt-code-reviews.appspot.com/1295806/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to