The whitespace is me cutting and pasting. I trimmed the function of some stuff that wasn't pertinent to the problem.
On Wed, Feb 9, 2011 at 10:50 AM, John Tamplin <[email protected]> wrote: > On Wed, Feb 9, 2011 at 10:43 AM, <[email protected]> wrote: >> >> I did a spot check. There is one odd thing that happens with the new >> settings on eclipse 3.5 (found in JsCatchScope) >> >> @Override >> protected JsName findExistingNameNoRecurse(String ident) { >> if (name.getIdent().equals(ident)) { >> return name; >> } >> } >> >> becomes >> >> @Override >> protected JsName findExistingNameNoRecurse(String ident) { >> if (name.getIdent() >> .equals(ident)) { >> return name; >> } >> } > > Yes, we have lots of cases like this, where 2 or 3 method calls are chained > but not in a builder pattern. I suggest just letting it break before a dot > if it needs to in order to fit on the line, but not force it. > Also, shouldn't the .equals line be indented 2 more? And where did the > extra blank line come from? > > -- > John A. Tamplin > Software Engineer (GWT), Google > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors -- Eric Z. Ayers Google Web Toolkit, Atlanta, GA USA -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
