The intention was all but the first call on its own line, and was not very
well thought out — I had builders on the brain. There is another option to
have it wrap when it needs to, which we have turned off at the moment. I'll
set it to that and do more spot checks.

On Wed, Feb 9, 2011 at 7:56 AM, Eric Ayers <zun...@google.com> wrote:

> Was the intention to require all expressions to be put on a new line,
> or only when the dots are preceeded by whitespace?
>
> On Wed, Feb 9, 2011 at 10:48 AM, Ray Ryan <rj...@google.com> wrote:
> > That's pretty bad. I'll tweak. Even if we can't have perfect builders we
> can
> > at least wrap long lines better.
> >
> > On Feb 9, 2011 7:43 AM, <zun...@google.com> wrote:
> >> I did a spot check. There is one odd thing that happens with the new
> >> settings on eclipse 3.5 (found in JsCatchScope)
> >>
> >> @Override
> >> protected JsName findExistingNameNoRecurse(String ident) {
> >> if (name.getIdent().equals(ident)) {
> >> return name;
> >> }
> >> }
> >>
> >> becomes
> >>
> >> @Override
> >> protected JsName findExistingNameNoRecurse(String ident) {
> >> if (name.getIdent()
> >> .equals(ident)) {
> >> return name;
> >> }
> >> }
> >>
> >> http://gwt-code-reviews.appspot.com/1346803/show
> >
>
>
>
> --
> Eric Z. Ayers
> Google Web Toolkit, Atlanta, GA USA
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to