http://gwt-code-reviews.appspot.com/1374802/diff/1/user/src/com/google/gwt/junit/JUnitShell.java File user/src/com/google/gwt/junit/JUnitShell.java (right):
http://gwt-code-reviews.appspot.com/1374802/diff/1/user/src/com/google/gwt/junit/JUnitShell.java#newcode163 user/src/com/google/gwt/junit/JUnitShell.java:163: options.setServletContainerLauncher(shell.new MyJettyLauncher()); Wow. I've never seen that shell.new thing before, or at least I'd forgotten about it. Should you give shell a createJettyLauncher method instead? And perhaps move this now static class into its own file? http://gwt-code-reviews.appspot.com/1374802/diff/1/user/src/com/google/gwt/junit/JUnitShell.java#newcode438 user/src/com/google/gwt/junit/JUnitShell.java:438: return "Run each test using an HTML document in standards mode (rather than quirks mode)"; nice http://gwt-code-reviews.appspot.com/1374802/diff/1/user/src/com/google/gwt/junit/JUnitShell.java#newcode1102 user/src/com/google/gwt/junit/JUnitShell.java:1102: // CHECKSTYLE_OFF what is checkstyle complaining about? http://gwt-code-reviews.appspot.com/1374802/diff/1/user/test/com/google/gwt/junit/JUnitShellTest.java File user/test/com/google/gwt/junit/JUnitShellTest.java (right): http://gwt-code-reviews.appspot.com/1374802/diff/1/user/test/com/google/gwt/junit/JUnitShellTest.java#newcode23 user/test/com/google/gwt/junit/JUnitShellTest.java:23: public class JUnitShellTest extends TestCase { Thanks. http://gwt-code-reviews.appspot.com/1374802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
