http://gwt-code-reviews.appspot.com/1374802/diff/1/user/src/com/google/gwt/junit/JUnitShell.java File user/src/com/google/gwt/junit/JUnitShell.java (right):
http://gwt-code-reviews.appspot.com/1374802/diff/1/user/src/com/google/gwt/junit/JUnitShell.java#newcode163 user/src/com/google/gwt/junit/JUnitShell.java:163: options.setServletContainerLauncher(shell.new MyJettyLauncher()); On 2011/03/03 18:29:54, rjrjr wrote:
Wow. I've never seen that shell.new thing before, or at least I'd
forgotten
about it.
Yeah, I had forgotten about it too, but it's in several other places in this file, which could certainly use some cleanup. I think these could all be fixed by making inner classes static. But this seemed like enough refactoring for one CL. http://gwt-code-reviews.appspot.com/1374802/diff/1/user/src/com/google/gwt/junit/JUnitShell.java#newcode1102 user/src/com/google/gwt/junit/JUnitShell.java:1102: // CHECKSTYLE_OFF On 2011/03/03 18:29:54, rjrjr wrote:
what is checkstyle complaining about?
Don't know; I just copied it. Maybe the += on a string? Removed, and it seemed to pass. http://gwt-code-reviews.appspot.com/1374802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
