http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right):
http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode2 dev/core/src/com/google/gwt/dev/CompileModule.java:2: * Copyright 2010 Google Inc. I actually did write this in 2010. :) But fixed. http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode61 dev/core/src/com/google/gwt/dev/CompileModule.java:61: * Compiles a GWT module. Just current state. Might even do incremental commits, but the plan is that this will be the entry point to compile a module. http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (right): http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode213 dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:213: * contain unresolved references. Yes, this is a refactoring of GenerateJavaAST. Basically, I want to have them both in place, and working, and then I'll flip a bit to switch from one to the other permanently. Once that's been well-vetted, there will be a whole lot of stuff to remove, including the whole WebModeCompilerFrontEnd snarl. The old processXXX stuff was reflection-driven code. This implementation uses the real JDT visitors. http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode258 dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:258: if (field.isCompileTimeConstant()) { No, the assert in GenJavaAst is new (it used to be a runtime error check, but that check moved to JsniChecker). Added the assert here (and moved in processClassLiteral). http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode354 dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:354: --i; On 2011/03/07 19:39:43, zundel wrote:
um, this is weird. change the for expression or use a while loop.
Done. http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode415 dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:415: int binOp = (x.bits & ASTNode.OperatorMASK) >> ASTNode.OperatorSHIFT; GenJavaAst will die. http://gwt-code-reviews.appspot.com/1373805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
