On Tue, Mar 8, 2011 at 9:36 PM, <[email protected]> wrote: > Okay.. so should I submit this? That way, future reviews will be vs. > trunk. > > Maybe I should add a basic unit test to make sure that this at least > doesn't crash, and maybe even that the output is the same as the web > mode compiler for some test file. > > I'm in favor of that.
> > > > http://gwt-code-reviews.appspot.com/1373805/diff/6001/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java > File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java > (right): > > > http://gwt-code-reviews.appspot.com/1373805/diff/6001/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode1595 > dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:1595: // SEE > NOTE ON JDT FORCED OPTIMIZATIONS > Oops, must have lost it. Will fix. > > > http://gwt-code-reviews.appspot.com/1373805/ > -- Eric Z. Ayers Google Web Toolkit, Atlanta, GA USA -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
