http://gwt-code-reviews.appspot.com/1384801/diff/3003/user/src/com/google/gwt/safecss/shared/SafeCssPropertiesUtils.java File user/src/com/google/gwt/safecss/shared/SafeCssPropertiesUtils.java (right):
http://gwt-code-reviews.appspot.com/1384801/diff/3003/user/src/com/google/gwt/safecss/shared/SafeCssPropertiesUtils.java#newcode22 user/src/com/google/gwt/safecss/shared/SafeCssPropertiesUtils.java:22: public final class SafeCssPropertiesUtils { On 2011/03/11 22:27:14, rjrjr wrote:
I think this should still be SafeCssUtils
Done. http://gwt-code-reviews.appspot.com/1384801/diff/3003/user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java File user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java (right): http://gwt-code-reviews.appspot.com/1384801/diff/3003/user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java#newcode301 user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java:301: throw new UnableToCompleteException(); On 2011/03/11 22:27:14, rjrjr wrote:
The other IllegalStateExceptions thrown here should be converted as
well, didn't
notice you were following existing code.
Might be worth looking to see if he's catching those and converting
them to
UnableToComplete exception somewhere or something crafty like that.
Done. I didn't even notice that he used them. I switched to use the convenience method AbstractSourceCreator#error(). I don't see any special handling of exceptions, and it looks like error() was used elsewhere in the code. http://gwt-code-reviews.appspot.com/1384801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
