Seems basically fine. I'm just wondering if we're missing anything.
http://gwt-code-reviews.appspot.com/1384801/diff/3003/user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java File user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java (right): http://gwt-code-reviews.appspot.com/1384801/diff/3003/user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java#newcode80 user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java:80: public void testTemplateWithCssAttribute() { On 2011/03/14 17:03:18, jlabanca wrote:
The & character is valid because it can be used in a URL: background:url(http://url?image=123112&size=1024)
I'm wondering if this is more correct: background:url(http://url?image=123112&size=1024); Similarly, can we use other HTML entities like " within a SafeCssProperties string? http://gwt-code-reviews.appspot.com/1384801/diff/3008/user/src/com/google/gwt/cell/client/IconCellDecorator.java File user/src/com/google/gwt/cell/client/IconCellDecorator.java (right): http://gwt-code-reviews.appspot.com/1384801/diff/3008/user/src/com/google/gwt/cell/client/IconCellDecorator.java#newcode196 user/src/com/google/gwt/cell/client/IconCellDecorator.java:196: String cssString = direction + ":0px;"; To remove a bit of duplication, maybe make this variable have type SafeCssProperties? http://gwt-code-reviews.appspot.com/1384801/diff/3008/user/src/com/google/gwt/cell/client/IconCellDecorator.java#newcode203 user/src/com/google/gwt/cell/client/IconCellDecorator.java:203: cssString += "margin-top:-" + halfHeight + "px;"; We should have some way of concatenating two variables of type SafeCssProperties. http://gwt-code-reviews.appspot.com/1384801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
