I had reviewed this after all, but forgot to click send. D'oh! Sorry for the delay.
http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/DomEvent.gwt.xml File user/src/com/google/gwt/event/dom/DomEvent.gwt.xml (right): http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/DomEvent.gwt.xml#newcode3 user/src/com/google/gwt/event/dom/DomEvent.gwt.xml:3: <inherits name="com.google.gwt.dom.DOM" /> Can you alphabetize these? http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/client/TouchEvent.java File user/src/com/google/gwt/event/dom/client/TouchEvent.java (right): http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/client/TouchEvent.java#newcode35 user/src/com/google/gwt/event/dom/client/TouchEvent.java:35: private static class TouchSupportDetector { This name is a bit confusing since it will return false for a tablet Android device, which does fire touch events. If that fact is javadoc'ed, I think things would be ok. Alternatively, have TouchSupportDetector and a separate check for the touch-based scrolling. http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/user/tools/templates/eclipse/_moduleShortName_.launch File user/src/com/google/gwt/user/tools/templates/eclipse/_moduleShortName_.launch (left): http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/user/tools/templates/eclipse/_moduleShortName_.launch#oldcode1 user/src/com/google/gwt/user/tools/templates/eclipse/_moduleShortName_.launch:1: <?xml version="1.0" encoding="UTF-8"?> Was deleting this a mistake? http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/test/com/google/gwt/touch/client/TouchScrollTest.java File user/test/com/google/gwt/touch/client/TouchScrollTest.java (right): http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/test/com/google/gwt/touch/client/TouchScrollTest.java#newcode513 user/test/com/google/gwt/touch/client/TouchScrollTest.java:513: } You removed a test called isTouchSupported() that I was fond of. I'd recommend adding a test to double-check that your support check works. Something like if(browser == android && tablet && elem.ontouchstart == "function") { assertTrue(TouchScroller.isSupported()); } http://gwt-code-reviews.appspot.com/1369809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
