http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/DomEvent.gwt.xml File user/src/com/google/gwt/event/dom/DomEvent.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/DomEvent.gwt.xml#newcode3 user/src/com/google/gwt/event/dom/DomEvent.gwt.xml:3: <inherits name="com.google.gwt.dom.DOM" /> On 2011/03/14 18:09:14, pdr wrote:
Can you alphabetize these?
Done. http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/client/TouchEvent.java File user/src/com/google/gwt/event/dom/client/TouchEvent.java (right): http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/client/TouchEvent.java#newcode35 user/src/com/google/gwt/event/dom/client/TouchEvent.java:35: private static class TouchSupportDetector { This would return true for a tablet Android device. TouchScroller has the second check for Android, as you described. http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/user/tools/templates/eclipse/_moduleShortName_.launch File user/src/com/google/gwt/user/tools/templates/eclipse/_moduleShortName_.launch (left): http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/user/tools/templates/eclipse/_moduleShortName_.launch#oldcode1 user/src/com/google/gwt/user/tools/templates/eclipse/_moduleShortName_.launch:1: <?xml version="1.0" encoding="UTF-8"?> On 2011/03/14 18:09:14, pdr wrote:
Was deleting this a mistake?
Yes, reverting http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/test/com/google/gwt/touch/client/TouchScrollTest.java File user/test/com/google/gwt/touch/client/TouchScrollTest.java (right): http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/test/com/google/gwt/touch/client/TouchScrollTest.java#newcode513 user/test/com/google/gwt/touch/client/TouchScrollTest.java:513: } isTouchSupported() was a helper method to determine if TouchScroller should be supported in this test. However, now that the detection is more complicated, copying TouchScroller.isSupport() seems redundant. I agree in principle that it would be nice to verify that TouchScroller.isSupported() returns the correct value on the correct device, but if we just copy the implementation of TouchScroller.isSupported(), then it isn't really testing anything. http://gwt-code-reviews.appspot.com/1369809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
