LGTM I think you probably meant "codec" rather than "codex", but I can understand if this name change would be too much at this point.
I hate the word "reify", I don't really understand what it means and I doubt 99% of our users will either. Can you add a juicy comment somewhere that explains what it means in this context? http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/rebind/AutoBeanFactoryGenerator.java File user/src/com/google/gwt/autobean/rebind/AutoBeanFactoryGenerator.java (right): http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/rebind/AutoBeanFactoryGenerator.java#newcode235 user/src/com/google/gwt/autobean/rebind/AutoBeanFactoryGenerator.java:235: sw.println("%s toReturn = getOrReify(\"%s\");", castType, method.getPropertyName()); two spaces after = http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/FactoryHandler.java File user/src/com/google/gwt/autobean/server/impl/FactoryHandler.java (right): http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/FactoryHandler.java#newcode77 user/src/com/google/gwt/autobean/server/impl/FactoryHandler.java:77: Whitespace-only change http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java File user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java (left): http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java#oldcode65 user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java:65: * Private equivalent of org.json.JSONObject.getNames(JSONObject) Please restore this method and remove call to JSONObject.getNames below (in getPropertyKeys). http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java File user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java (right): http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java#newcode194 user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java:194: String[] names = JSONObject.getNames(obj); Call local getNames method (for Android compatibility) http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/ProxyAutoBean.java File user/src/com/google/gwt/autobean/server/impl/ProxyAutoBean.java (right): http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/ProxyAutoBean.java#newcode180 user/src/com/google/gwt/autobean/server/impl/ProxyAutoBean.java:180: return null; Does this need a doc comment (to indicate that it's a stub implementation)? http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java File user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java (right): http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java#newcode27 user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java:27: public class AutoBeanCodex { Do you mean 'codec'? (coder/decoder) http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/shared/ValueCodex.java File user/src/com/google/gwt/autobean/shared/ValueCodex.java (right): http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/shared/ValueCodex.java#newcode31 user/src/com/google/gwt/autobean/shared/ValueCodex.java:31: public class ValueCodex { Codec? http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/shared/impl/AutoBeanCodexImpl.java File user/src/com/google/gwt/autobean/shared/impl/AutoBeanCodexImpl.java (right): http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/shared/impl/AutoBeanCodexImpl.java#newcode40 user/src/com/google/gwt/autobean/shared/impl/AutoBeanCodexImpl.java:40: public class AutoBeanCodexImpl { Codec http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/shared/impl/SplittableSet.java File user/src/com/google/gwt/autobean/shared/impl/SplittableSet.java (right): http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/shared/impl/SplittableSet.java#newcode26 user/src/com/google/gwt/autobean/shared/impl/SplittableSet.java:26: * This type is optimized for the read-only case. Might want to note that contains() is O(n)? http://gwt-code-reviews.appspot.com/1407802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
