reify := "make real"

I found a couple of bugs running internal test suites that have been
fixed in the latest patch with a test added to the GWT code base.


http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/rebind/AutoBeanFactoryGenerator.java
File
user/src/com/google/gwt/autobean/rebind/AutoBeanFactoryGenerator.java
(right):

http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/rebind/AutoBeanFactoryGenerator.java#newcode235
user/src/com/google/gwt/autobean/rebind/AutoBeanFactoryGenerator.java:235:
sw.println("%s toReturn =  getOrReify(\"%s\");", castType,
method.getPropertyName());
On 2011/04/06 20:32:26, rice wrote:
two spaces after =

Done.

http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/FactoryHandler.java
File user/src/com/google/gwt/autobean/server/impl/FactoryHandler.java
(right):

http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/FactoryHandler.java#newcode77
user/src/com/google/gwt/autobean/server/impl/FactoryHandler.java:77:
On 2011/04/06 20:32:26, rice wrote:
Whitespace-only change

Done.

http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java
File user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java
(left):

http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java#oldcode65
user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java:65: *
Private equivalent of org.json.JSONObject.getNames(JSONObject)
On 2011/04/06 20:32:26, rice wrote:
Please restore this method and remove call to JSONObject.getNames
below (in
getPropertyKeys).

Done.

http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java
File user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java
(right):

http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java#newcode194
user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java:194:
String[] names = JSONObject.getNames(obj);
On 2011/04/06 20:32:26, rice wrote:
Call local getNames method (for Android compatibility)

Done.

http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/ProxyAutoBean.java
File user/src/com/google/gwt/autobean/server/impl/ProxyAutoBean.java
(right):

http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/server/impl/ProxyAutoBean.java#newcode180
user/src/com/google/gwt/autobean/server/impl/ProxyAutoBean.java:180:
return null;
On 2011/04/06 20:32:26, rice wrote:
Does this need a doc comment (to indicate that it's a stub
implementation)?

Done.

http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java
File user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java (right):

http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java#newcode27
user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java:27: public
class AutoBeanCodex {
On 2011/04/06 20:32:26, rice wrote:
Do you mean 'codec'?  (coder/decoder)

It's a pun.

http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/shared/impl/SplittableSet.java
File user/src/com/google/gwt/autobean/shared/impl/SplittableSet.java
(right):

http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/shared/impl/SplittableSet.java#newcode26
user/src/com/google/gwt/autobean/shared/impl/SplittableSet.java:26: *
This type is optimized for the read-only case.
On 2011/04/06 20:32:26, rice wrote:
Might want to note that contains() is O(n)?

Done.

http://gwt-code-reviews.appspot.com/1407802/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to