[gwt-contrib] Re: Users found that the error spam reduction hid too many errors. This change (issue1416801)

[zundel]

Updated patch.


http://gwt-code-reviews.appspot.com/1416801/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
File
dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
(right):

http://gwt-code-reviews.appspot.com/1416801/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java#newcode206
dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java:206:
String topLevelType = typeName.replaceAll("\\$.*$", "");
On 2011/04/13 19:57:18, tobyr wrote:

The use of "$'s" for nested types is just naming convention. For

example, I can

name a top-level class "Foo$", without any problems.

You don't want to have to linear-scan over the unitMap to find the

matching

CompilationUnit, so you should probably build an index from all types

(including

nested) to CompilationUnits.

Good idea - Done.

http://gwt-code-reviews.appspot.com/1416801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors