http://gwt-code-reviews.appspot.com/1416801/diff/1/dev/core/src/com/google/gwt/dev/javac/Shared.java File dev/core/src/com/google/gwt/dev/javac/Shared.java (right):
http://gwt-code-reviews.appspot.com/1416801/diff/1/dev/core/src/com/google/gwt/dev/javac/Shared.java#newcode159 dev/core/src/com/google/gwt/dev/javac/Shared.java:159: return internalName.replace('/', '.'); Use InternalName.toBinaryName() instead of creating this method. http://gwt-code-reviews.appspot.com/1416801/diff/4001/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java File dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java (right): http://gwt-code-reviews.appspot.com/1416801/diff/4001/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java#newcode250 dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java:250: } These seems unnecessary. Either CompilationState.getClassFileMap() or getClassFileMapBySource() should give you a correct way to map type to CompiledClass, then you just call cc.getUnit(). http://gwt-code-reviews.appspot.com/1416801/diff/4001/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java#newcode270 dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java:270: } Did you track down why this is needed? Only errors related to api references will cause a type to go missing from TypeOracle. Assume Bar doesn't exist. class Foo1 { void f() { Bar.doSomething(); } } class Foo2 { Bar f(); } I believe that Foo2 will be removed from TypeOracle (because of the api reference to the non-existent Bar), but I don't believe Foo1 will be removed. http://gwt-code-reviews.appspot.com/1416801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
