I had to bring back the deprecated methods for HandlManager. HandlerManager needs to be JRE compatible, so violator is not an option. Duh.
The patch is also updated to catch up with the AutoBean migration, and to move the RF test classes to the new event package. All tests pass now. http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/gwt/event/shared/HandlerManager.java File user/src/com/google/gwt/event/shared/HandlerManager.java (right): http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/gwt/event/shared/HandlerManager.java#newcode49 user/src/com/google/gwt/event/shared/HandlerManager.java:49: @com.google.web.bindery.event.shared.SimpleEventBus::doRemove(Lcom/google/web/bindery/event/shared/Event$Type;Ljava/lang/Object;Ljava/lang/Object;) Oooh, forgot about that. Thanks! On 2011/04/15 14:25:56, bobv wrote:
Can you use the JSNI wildcard syntax here?
http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/gwt/event/shared/UmbrellaException.java File user/src/com/google/gwt/event/shared/UmbrellaException.java (right): http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/gwt/event/shared/UmbrellaException.java#newcode32 user/src/com/google/gwt/event/shared/UmbrellaException.java:32: protected UmbrellaException() { On 2011/04/15 12:59:33, jlabanca wrote:
extra space
Done. http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/web/bindery/event/shared/SimpleEventBus.java File user/src/com/google/web/bindery/event/shared/SimpleEventBus.java (right): http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/web/bindery/event/shared/SimpleEventBus.java#newcode60 user/src/com/google/web/bindery/event/shared/SimpleEventBus.java:60: if (type == null) { Good catch, thanks. You'll be pleased and surprised to learn that the test already exists and was failing. I just hadn't noticed yet. On 2011/04/15 12:59:33, jlabanca wrote:
You should check that source == null here, not type == null. type ==
null is
checked in doAdd.
Probably should add a test case too.
http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/web/bindery/event/shared/UmbrellaException.java File user/src/com/google/web/bindery/event/shared/UmbrellaException.java (right): http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/web/bindery/event/shared/UmbrellaException.java#newcode54 user/src/com/google/web/bindery/event/shared/UmbrellaException.java:54: this(new HashSet<Throwable>()); On 2011/04/15 12:59:33, jlabanca wrote:
Collections.emptySet() might be cheaper.
Done. http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java File user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java (right): http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java#newcode72 user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java:72: counts.put(type, getCountObject(type) - 1); I would swear on a stack of bibles that it didn't last night. Fixed. On 2011/04/15 12:59:33, jlabanca wrote:
Do you need getCountObject? I'm pretty sure getCount(type) - 1 will
autobox
into an Integer.
http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/test/com/google/web/bindery/event/shared/BarEvent.java File user/test/com/google/web/bindery/event/shared/BarEvent.java (right): http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/test/com/google/web/bindery/event/shared/BarEvent.java#newcode17 user/test/com/google/web/bindery/event/shared/BarEvent.java:17: On 2011/04/15 14:25:56, bobv wrote:
Extra blank line.
Done. http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/test/com/google/web/bindery/event/shared/EventBusTestBase.java File user/test/com/google/web/bindery/event/shared/EventBusTestBase.java (right): http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/test/com/google/web/bindery/event/shared/EventBusTestBase.java#newcode19 user/test/com/google/web/bindery/event/shared/EventBusTestBase.java:19: On 2011/04/15 14:25:56, bobv wrote:
Extra blank lines.
Done. http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/test/com/google/web/bindery/event/shared/EventSharedSuite.java File user/test/com/google/web/bindery/event/shared/EventSharedSuite.java (right): http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/test/com/google/web/bindery/event/shared/EventSharedSuite.java#newcode29 user/test/com/google/web/bindery/event/shared/EventSharedSuite.java:29: suite.addTestSuite(com.google.web.bindery.event.shared.ResettableEventBusTest.class); On 2011/04/15 14:25:56, bobv wrote:
Use import statements?
Done. http://gwt-code-reviews.appspot.com/1394803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
