LGTM
http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/gwt/event/shared/UmbrellaException.java File user/src/com/google/gwt/event/shared/UmbrellaException.java (right): http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/gwt/event/shared/UmbrellaException.java#newcode32 user/src/com/google/gwt/event/shared/UmbrellaException.java:32: protected UmbrellaException() { extra space http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/web/bindery/event/shared/SimpleEventBus.java File user/src/com/google/web/bindery/event/shared/SimpleEventBus.java (right): http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/web/bindery/event/shared/SimpleEventBus.java#newcode60 user/src/com/google/web/bindery/event/shared/SimpleEventBus.java:60: if (type == null) { You should check that source == null here, not type == null. type == null is checked in doAdd. Probably should add a test case too. http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/web/bindery/event/shared/UmbrellaException.java File user/src/com/google/web/bindery/event/shared/UmbrellaException.java (right): http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/web/bindery/event/shared/UmbrellaException.java#newcode54 user/src/com/google/web/bindery/event/shared/UmbrellaException.java:54: this(new HashSet<Throwable>()); Collections.emptySet() might be cheaper. http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java File user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java (right): http://gwt-code-reviews.appspot.com/1394803/diff/10001/user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java#newcode72 user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java:72: counts.put(type, getCountObject(type) - 1); Do you need getCountObject? I'm pretty sure getCount(type) - 1 will autobox into an Integer. http://gwt-code-reviews.appspot.com/1394803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
