LGTM
http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java File user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java (right): http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java#newcode52 user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java:52: @SuppressWarnings("deprecation") can this be more localized? http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/shared/Receiver.java File user/src/com/google/web/bindery/requestfactory/shared/Receiver.java (right): http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/shared/Receiver.java#newcode74 user/src/com/google/web/bindery/requestfactory/shared/Receiver.java:74: * type. Nice touch. http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/shared/Receiver.java#newcode76 user/src/com/google/web/bindery/requestfactory/shared/Receiver.java:76: * @param errors a Set of {@link Violation} instances a set of what instances? http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/shared/messages/ViolationMessage.java File user/src/com/google/web/bindery/requestfactory/shared/messages/ViolationMessage.java (right): http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/shared/messages/ViolationMessage.java#newcode28 user/src/com/google/web/bindery/requestfactory/shared/messages/ViolationMessage.java:28: String TEMPATE = "T"; tempLate http://gwt-code-reviews.appspot.com/1422809/diff/1/user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java File user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java (right): http://gwt-code-reviews.appspot.com/1422809/diff/1/user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java#newcode505 user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java:505: @SuppressWarnings("deprecation") can you isolate the deprecated part to a separate method? http://gwt-code-reviews.appspot.com/1422809/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryExceptionPropagationTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryExceptionPropagationTest.java (right): http://gwt-code-reviews.appspot.com/1422809/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryExceptionPropagationTest.java#newcode62 user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryExceptionPropagationTest.java:62: public void onViolation(Set<com.google.web.bindery.requestfactory.shared.Violation> errors) { Should add a counter for the onConstraintViolation as well. Then let it call through to super to maintain coverage of the compatibility code. Or, if that's out of scope for this test, just convert to the new method? http://gwt-code-reviews.appspot.com/1422809/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/1422809/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java#newcode55 user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java:55: public class RequestFactoryTest extends RequestFactoryTestBase { Hard to tease out the real change from the autodiff. Anything particularly important? http://gwt-code-reviews.appspot.com/1422809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
