r10053
http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java File user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java (right): http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java#newcode52 user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java:52: @SuppressWarnings("deprecation") Every field and method in this class, save getUserDataObject(), shows a deprecation warning. http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/shared/Receiver.java File user/src/com/google/web/bindery/requestfactory/shared/Receiver.java (right): http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/shared/Receiver.java#newcode76 user/src/com/google/web/bindery/requestfactory/shared/Receiver.java:76: * @param errors a Set of {@link Violation} instances On 2011/04/21 18:49:32, rjrjr wrote:
a set of what instances?
Done. http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/shared/messages/ViolationMessage.java File user/src/com/google/web/bindery/requestfactory/shared/messages/ViolationMessage.java (right): http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/shared/messages/ViolationMessage.java#newcode28 user/src/com/google/web/bindery/requestfactory/shared/messages/ViolationMessage.java:28: String TEMPATE = "T"; On 2011/04/21 18:49:32, rjrjr wrote:
tempLate
Done. http://gwt-code-reviews.appspot.com/1422809/diff/1/user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java File user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java (right): http://gwt-code-reviews.appspot.com/1422809/diff/1/user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java#newcode505 user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java:505: @SuppressWarnings("deprecation") On 2011/04/21 18:49:32, rjrjr wrote:
can you isolate the deprecated part to a separate method?
Done. http://gwt-code-reviews.appspot.com/1422809/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryExceptionPropagationTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryExceptionPropagationTest.java (right): http://gwt-code-reviews.appspot.com/1422809/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryExceptionPropagationTest.java#newcode62 user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryExceptionPropagationTest.java:62: public void onViolation(Set<com.google.web.bindery.requestfactory.shared.Violation> errors) { On 2011/04/21 18:49:32, rjrjr wrote:
Should add a counter for the onConstraintViolation as well. Then let
it call
through to super to maintain coverage of the compatibility code.
Or, if that's out of scope for this test, just convert to the new
method? Done. http://gwt-code-reviews.appspot.com/1422809/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/1422809/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java#newcode55 user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java:55: public class RequestFactoryTest extends RequestFactoryTestBase { Just copied any tests on onViolation() into a matching onConstraintViolation() that forwards to the default Receiver.onConstraintViolation(). http://gwt-code-reviews.appspot.com/1422809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
