I addressed the feedback (including Brian's one, adding a paragraph to
SafeUri javadoc) and formatted the files.
http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/resources/client/ImageResource.java
File user/src/com/google/gwt/resources/client/ImageResource.java
(right):
http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/resources/client/ImageResource.java#newcode127
user/src/com/google/gwt/resources/client/ImageResource.java:127: String
getURL();
On 2011/04/27 18:01:32, jat wrote:
Should this be deprecated?
Done.
http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/resources/rg/DataResourceGenerator.java
File user/src/com/google/gwt/resources/rg/DataResourceGenerator.java
(right):
http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/resources/rg/DataResourceGenerator.java#newcode68
user/src/com/google/gwt/resources/rg/DataResourceGenerator.java:68:
sw.println("new " + DataResourcePrototype.class.getName() + "(");
On 2011/04/27 18:01:32, jat wrote:
Should this be getCanonicalName()? In this case they are the same,
but in
general getName() is not going to return a name you can use in the
source.
If you change, change them all in this change.
ALL resource generators, and a whole bunch of other classes use
getName() instead getCanonicalName() (there's even a
getName().replace('$','.') in GwtCreateResourceGenerator!) so I'm gonna
leave them as is.
Moreover, those classes are public API so they're not going to turn into
nested classes, unexpectedly breaking the generator, so I think it's OK
to use getName() in this case (getCanonicalName would be better, but
getName is OK).
http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java
File user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java
(right):
http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java#newcode481
user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java:481:
new String[]{bundle.getNormalContentsFieldName(),
bundle.getRtlContentsFieldName()};
On 2011/04/27 18:01:32, jat wrote:
space between ] and {
Done.
http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java
File
user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java
(right):
http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java#newcode302
user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java:302:
// TODO(xtof): refactor HtmlContext with isStart/isEnd/isEntire
accessors an simplified type.
On 2011/04/27 17:18:58, xtof wrote:
an[d] simplified?
Done.
http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/user/client/ui/Image.java
File user/src/com/google/gwt/user/client/ui/Image.java (right):
http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/user/client/ui/Image.java#newcode301
user/src/com/google/gwt/user/client/ui/Image.java:301: public abstract
void setVisibleRect(Image image, int left, int top, int width, int
height);
On 2011/04/27 18:01:32, jat wrote:
On 2011/04/27 17:18:58, xtof wrote:
> Maybe undo this line wrap?
Since we changed to 100 chars, my understanding is each file when
edited should
be reformatted, though ideally as a separate change to avoid
obfuscating the
real change. In this case, I don't care much either way.
Done.
http://gwt-code-reviews.appspot.com/1380806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
