On 2011/06/01 04:48:04, xtof wrote:
On 2011/06/01 00:10:58, tbroyer wrote: > On 2011/05/31 23:38:17, xtof wrote: > > My apologies dropping the response on this thread (I'd missed the
last
> > question and had assumed this was good to submit). > > > > Also, I didn't realize that I actually need to fetch and submit
this patch
> > (I'm not part of GWT team proper and wasn't familiar with the
process for
> > changes from external developers). > > No problem. > > Otherwise, proposed changes SGTM.
I can't seem to upload an updated patch set for this issue (presumably
since you
created it). I'll mail you the patch set separately.
I hope I didn't mess things up during the merge, as I couldn't simply upload the patch to Rietveld (when you create an issue with git-cl/upload.py, it appears that you cannot update it "manually" afterwards; and I couldn't find an option to upload.py to give it the patch file either). Alternatively, you could create another issue in Rietveld… http://gwt-code-reviews.appspot.com/1380806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
