Please tell me that this is the last step in the following chain. It seems unlikely if you're only providing the property now.
First you provide the property to allow quirks, and give compiler warnings that only go away if you set standards mode or set the quirks property. (And publicize that it will be the default in the next release.) Then you change the default and break existing apps. This change should also include updates to the javadoc of widgets that require quirks to point to the new property. On May 4, 2011 7:38 AM, <jlaba...@google.com> wrote: > This is a breaking change for existing apps that run in quirks mode. > I'm alright with that because I don't see an alternative, but we'll need > to call if out in the release notes and tell people the workaround. > > > http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/UserAgent.gwt.xml > File user/src/com/google/gwt/user/UserAgent.gwt.xml (right): > > http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/UserAgent.gwt.xml#newcode29 > user/src/com/google/gwt/user/UserAgent.gwt.xml:29: > extra newline > > http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/UserAgent.gwt.xml#newcode56 > user/src/com/google/gwt/user/UserAgent.gwt.xml:56: > <define-configuration-property name="document.compatMode" > I think we should break this out into a separate DocumentMode.gwt.xml > file and inherit it in User.gwt.xml. It isn't part of the UserAgent. > > http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/UserAgent.gwt.xml#newcode67 > user/src/com/google/gwt/user/UserAgent.gwt.xml:67: > extra newline > > http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/client/DocumentModeAsserter.java > File user/src/com/google/gwt/user/client/DocumentModeAsserter.java > (right): > > http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/client/DocumentModeAsserter.java#newcode27 > user/src/com/google/gwt/user/client/DocumentModeAsserter.java:27: * > rendering mode is of of the values allowed by the > /r/of of/one of > > http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java > File user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java > (right): > > http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java#newcode49 > user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java:49: > logger.log(TreeLogger.ERROR, "OOPS", e); > Maybe something better than OOPS > > http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java#newcode57 > user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java:57: > JClassType remoteService = typeOracle.findType(typeName); > Isn't removeService the same as userType? > > http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java#newcode76 > user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java:76: > logger.log(TreeLogger.WARN, "Unable to find value for '" > If we are going to throw an exception, this should be an ERROR instead > of a WARN > > http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java#newcode102 > user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java:102: for > (Iterator<String> iterator = documentModes.iterator(); > iterator.hasNext();) { > You can shorten this to: > for (String next : documentModes) { > > http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java#newcode103 > user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java:103: > sw.println("\"" + iterator.next() + "\", "); > This array will always end with a comma. Does Java handle that > correctly? > return new String[]{"a","b",}; > > http://gwt-code-reviews.appspot.com/1422816/ > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
