This change now introduces only a Development Mode warning (to the GWT
treelogger), which an option to suppress it (for those who know what
they are doing, or to raise the severity to a runtime error, which we
can do in a later release
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/UserAgent.gwt.xml
File user/src/com/google/gwt/user/UserAgent.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/UserAgent.gwt.xml#newcode29
user/src/com/google/gwt/user/UserAgent.gwt.xml:29:
On 2011/05/04 14:37:57, jlabanca wrote:
extra newline
Done.
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/UserAgent.gwt.xml#newcode56
user/src/com/google/gwt/user/UserAgent.gwt.xml:56:
<define-configuration-property name="document.compatMode"
On 2011/05/04 14:37:57, jlabanca wrote:
I think we should break this out into a separate DocumentMode.gwt.xml
file and
inherit it in User.gwt.xml. It isn't part of the UserAgent.
Done.
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/UserAgent.gwt.xml#newcode67
user/src/com/google/gwt/user/UserAgent.gwt.xml:67:
On 2011/05/04 14:37:57, jlabanca wrote:
extra newline
Done.
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/client/DocumentModeAsserter.java
File user/src/com/google/gwt/user/client/DocumentModeAsserter.java
(right):
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/client/DocumentModeAsserter.java#newcode27
user/src/com/google/gwt/user/client/DocumentModeAsserter.java:27: *
rendering mode is of of the values allowed by the
On 2011/05/04 14:37:57, jlabanca wrote:
/r/of of/one of
Done.
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java
File user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java
(right):
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java#newcode49
user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java:49:
logger.log(TreeLogger.ERROR, "OOPS", e);
On 2011/05/04 14:37:57, jlabanca wrote:
Maybe something better than OOPS
Done.
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java#newcode57
user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java:57:
JClassType remoteService = typeOracle.findType(typeName);
On 2011/05/04 14:37:57, jlabanca wrote:
Isn't removeService the same as userType?
YES!
Fixed.
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java#newcode76
user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java:76:
logger.log(TreeLogger.WARN, "Unable to find value for '"
On 2011/05/04 14:37:57, jlabanca wrote:
If we are going to throw an exception, this should be an ERROR instead
of a WARN
Done.
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java#newcode103
user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java:103:
sw.println("\"" + iterator.next() + "\", ");
On 2011/05/04 14:37:57, jlabanca wrote:
This array will always end with a comma. Does Java handle that
correctly?
return new String[]{"a","b",};
Yes
http://gwt-code-reviews.appspot.com/1422816/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
