LGTM if you make OrientationMonitor.provider() reference a singleton boolean instead of recalculating.
http://gwt-code-reviews.appspot.com/1433801/diff/3001/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactory.java File samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactory.java (right): http://gwt-code-reviews.appspot.com/1433801/diff/3001/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactory.java#newcode50 samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactory.java:50: * @return the local {@link Storage} object, or null unsupporting browsers /r/null unsupporting/null in unsupporting http://gwt-code-reviews.appspot.com/1433801/diff/3001/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ui/OrientationMonitor.java File samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ui/OrientationMonitor.java (right): http://gwt-code-reviews.appspot.com/1433801/diff/3001/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ui/OrientationMonitor.java#newcode43 samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ui/OrientationMonitor.java:43: return calculate(); Calling calculate() every time we access the getter could lead to performance degradation because the browser has to perform layout to calculate window.clientHeight/Width. Instead, can we use a singleton instance of OrientationMonitor to maintain an orientation bit and check it in the getter? http://gwt-code-reviews.appspot.com/1433801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
