Ready for another look. OrientationMonitor is replaced with OrientationHelper. John, I think I've stumbled onto a pretty nice widget plugin pattern there. I was able to delete the superclass for the shells without adding much boilerplate or copy/paste. What do you think?
Notice that I've snuck a method onto the HasAttachHandlers interface. I think we can get away with that since it's meant to be implemented by Widget — I'm willing to break a few tests to make it more useful. Hmm. I suppose I could instead introduce an interface into the demo code, IsAttachable extends HasAttachHandlers. The change sure feels right, though. http://gwt-code-reviews.appspot.com/1433801/diff/3001/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactory.java File samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactory.java (right): http://gwt-code-reviews.appspot.com/1433801/diff/3001/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactory.java#newcode50 samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactory.java:50: * @return the local {@link Storage} object, or null unsupporting browsers On 2011/05/04 20:29:44, jlabanca wrote:
/r/null unsupporting/null in unsupporting
Done. http://gwt-code-reviews.appspot.com/1433801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
