Mostly LG.

http://gwt-code-reviews.appspot.com/1441803/diff/4001/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1441803/diff/4001/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java#newcode407
dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java:407:
}
If I'm reading this correctly,
CachedCompilationUnit.asCachedCompilationUnit() returns the original
object, which you then modify.  I'm explicitly suggesting:

new CachedCompilationUnit(CachedCompilationUnit original, String
updatedResourceLocation, long updatedLastModified)

http://gwt-code-reviews.appspot.com/1441803/diff/4003/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java#newcode3
dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java:3: *
FYI: your EOL-fu is unhappy.

http://gwt-code-reviews.appspot.com/1441803/diff/4003/dev/core/test/com/google/gwt/dev/javac/MockCompilationUnit.java
File dev/core/test/com/google/gwt/dev/javac/MockCompilationUnit.java
(right):

http://gwt-code-reviews.appspot.com/1441803/diff/4003/dev/core/test/com/google/gwt/dev/javac/MockCompilationUnit.java#newcode56
dev/core/test/com/google/gwt/dev/javac/MockCompilationUnit.java:56:
return new CachedCompilationUnit(this, sourceToken, astToken);
Unfortunate, but understandable.

http://gwt-code-reviews.appspot.com/1441803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to