http://gwt-code-reviews.appspot.com/1441803/diff/4001/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right):
http://gwt-code-reviews.appspot.com/1441803/diff/4001/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java#newcode407 dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java:407: } On 2011/05/12 02:39:19, scottb wrote:
If I'm reading this correctly,
CachedCompilationUnit.asCachedCompilationUnit()
returns the original object, which you then modify. I'm explicitly
suggesting:
new CachedCompilationUnit(CachedCompilationUnit original, String updatedResourceLocation, long updatedLastModified)
OK, I see your pointnow. In this part of the code 'cachedUnit' is not necessarily an instance of CachedCompilationUnit so I had to add all this infrastructure to be able to get one. I was confused because in most places, asCachedCompilationUnit() does make a copy, but I forgot about CachedCompilationUnit itself. http://gwt-code-reviews.appspot.com/1441803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
