http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java File dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java (right):
http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java#newcode563 dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java:563: Will this preserve stable ordering for comparisons, when symbolic queryIds are used? http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java (right): http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode435 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:435: throw new InternalCompilerException("Unexpected exception parsing makeMapFunction", e); Is this the right exception message (specific to makeMapFunction)? Seems the method is "createGlobalFunction". http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode546 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:546: sb.append(" for (var i = 0, c = a.length; i < c; ++i) {"); Should this not be: "result[a[i]] = 1;" http://gwt-code-reviews.appspot.com/1449801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
