Thanks, Jason.

http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java
(right):

http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java#newcode563
dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java:563:
Yes, everything will be sorted by query id, which is stable.  In this
version of the patch, it's stable due to program structural traversal,
but in an update, I have an explicit sort where everything is alphabetic
except for Object and String which are special.

http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
(right):

http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode435
dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:435:
throw new InternalCompilerException("Unexpected exception parsing
makeMapFunction", e);
Good catch, it was due to a refactoring.  Will fix.

http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode546
dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:546:
sb.append("  for (var i = 0, c = a.length; i < c; ++i) {");
YES!  Good catch.. I figured this out the hard way. :)

http://gwt-code-reviews.appspot.com/1449801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to