And, as you pointed out, there is no need for the class name headers to
be clickable - could you remove that non-functioning clicking?


http://gwt-code-reviews.appspot.com/1443809/diff/1/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
File dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
(right):

http://gwt-code-reviews.appspot.com/1443809/diff/1/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java#newcode209
dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java:209:
outFile.print("b1(" + nameArray + ",");
Rename b1() and b2() to be one character names in order to save space in
the generated output.

http://gwt-code-reviews.appspot.com/1443809/diff/1/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java#newcode279
dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java:279:
outFile.println("    \"open\" : \"images/play-g16-down.png\",");
I assume these files will be checked in with the patch.

http://gwt-code-reviews.appspot.com/1443809/diff/1/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java#newcode327
dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java:327:
outFile.println("    document.write(\"<img onclick='swapShowHide(\\\"\"
+ "
fix the size of the icon when the element is created to avoid re-layout
once the image resource is loaded.

http://gwt-code-reviews.appspot.com/1443809/diff/1/dev/core/src/com/google/gwt/soyc/SizeBreakdown.java
File dev/core/src/com/google/gwt/soyc/SizeBreakdown.java (right):

http://gwt-code-reviews.appspot.com/1443809/diff/1/dev/core/src/com/google/gwt/soyc/SizeBreakdown.java#newcode27
dev/core/src/com/google/gwt/soyc/SizeBreakdown.java:27: public
Map<String, Integer> methodToSize = new HashMap<String, Integer>();
this and most of the other fields should probably be private final and
use accessors, but I won't make you go through and do all that.

http://gwt-code-reviews.appspot.com/1443809/diff/1/dev/core/src/com/google/gwt/soyc/resources/soyc.css
File dev/core/src/com/google/gwt/soyc/resources/soyc.css (right):

http://gwt-code-reviews.appspot.com/1443809/diff/1/dev/core/src/com/google/gwt/soyc/resources/soyc.css#newcode208
dev/core/src/com/google/gwt/soyc/resources/soyc.css:208:
.soyc-method-size-table {
? needed

http://gwt-code-reviews.appspot.com/1443809/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to