LGTM.
On 2011/06/01 16:53:38, rchandia wrote:
http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/README-MAVEN.txt
File samples/mobilewebapp/README-MAVEN.txt (right):
http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/README-MAVEN.txt#newcode24
samples/mobilewebapp/README-MAVEN.txt:24: select "Expenses".
s/Expenses/MobileWebApp/ ?
http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/README-MAVEN.txt#newcode34
samples/mobilewebapp/README-MAVEN.txt:34: - To load a set of initial
data
choose: LoadExpensesDB.html
Remove. There is a single entry point.
http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/README-MAVEN.txt#newcode36
samples/mobilewebapp/README-MAVEN.txt:36: - To run the Expenses
Application
choose: Expenses.html
Remove.
http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/README-MAVEN.txt#newcode39
samples/mobilewebapp/README-MAVEN.txt:39: ExpensesMobile.html
Remove.
http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/build.xml
File samples/mobilewebapp/build.xml (right):
http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/build.xml#newcode1
samples/mobilewebapp/build.xml:1: <project name="mobilewebapp"
default="build"
basedir=".">
A better default would be "source". samples/build.xml uses the
"source" target
when building this sample as it makes no sense to "build" it, being a
Maven
project.
http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java
File
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java
(right):
http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java#newcode29
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java:29:
public class AppCacheLinker extends SimpleAppCacheLinker {
The problem with having this class alongside src/main/java is that the
class
then ends up being shipped to the server (that is, it ends in the
packaged war).
The larger questions is how to handle GWTC-only dependencies in maven
(i.e.
custom linkers, generators, etc.) Talking with @drfibonacci it seems
the
approach will involve a muti-pom project, but if it works as it is
now, I do not
think we should make this a showstopper.
http://gwt-code-reviews.appspot.com/1450809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
