Thanks, submitting.
http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/README-MAVEN.txt File samples/mobilewebapp/README-MAVEN.txt (right): http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/README-MAVEN.txt#newcode24 samples/mobilewebapp/README-MAVEN.txt:24: select "Expenses". Changed it to "Select the directory containing this file," trying to keep thing generic. http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/README-MAVEN.txt#newcode34 samples/mobilewebapp/README-MAVEN.txt:34: - To load a set of initial data choose: LoadExpensesDB.html On 2011/06/01 16:53:38, rchandia wrote:
Remove. There is a single entry point.
Done. http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/README-MAVEN.txt#newcode36 samples/mobilewebapp/README-MAVEN.txt:36: - To run the Expenses Application choose: Expenses.html On 2011/06/01 16:53:38, rchandia wrote:
Remove.
Done. http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/README-MAVEN.txt#newcode39 samples/mobilewebapp/README-MAVEN.txt:39: ExpensesMobile.html On 2011/06/01 16:53:38, rchandia wrote:
Remove.
Done. http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/build.xml File samples/mobilewebapp/build.xml (right): http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/build.xml#newcode1 samples/mobilewebapp/build.xml:1: <project name="mobilewebapp" default="build" basedir="."> On 2011/06/01 16:53:38, rchandia wrote:
A better default would be "source". samples/build.xml uses the
"source" target
when building this sample as it makes no sense to "build" it, being a
Maven
project.
Done. http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/pom.xml File samples/mobilewebapp/pom.xml (right): http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/pom.xml#newcode35 samples/mobilewebapp/pom.xml:35: <repository> Deleted the gae staging block per offline feedback from Dave. http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java File samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java (right): http://gwt-code-reviews.appspot.com/1450809/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java#newcode29 samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java:29: public class AppCacheLinker extends SimpleAppCacheLinker { Ah, I see. Thanks for the explanation. @drfibonacci, my inclination is to leave this one in your court. The status quo strikes me as good enough for a sample, at least for now. That said, this sample is trying to be as correct as it can. If you have bandwidth to make it right, I'll work with you to get the fixes in. http://gwt-code-reviews.appspot.com/1450809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
