http://gwt-code-reviews.appspot.com/1450810/diff/3008/user/src/com/google/gwt/user/client/DOM.java
File user/src/com/google/gwt/user/client/DOM.java (right):
http://gwt-code-reviews.appspot.com/1450810/diff/3008/user/src/com/google/gwt/user/client/DOM.java#newcode57
user/src/com/google/gwt/user/client/DOM.java:57: * {@link
PotentialElement#finishBuild} method is called and then returned
On 2011/06/02 17:12:30, rjrjr wrote:
"and then" should be "and the"
Done.
http://gwt-code-reviews.appspot.com/1450810/diff/3008/user/src/com/google/gwt/user/client/DOM.java#newcode63
user/src/com/google/gwt/user/client/DOM.java:63: public static void
appendChild(Element parent, Element child) {
On 2011/06/02 17:12:30, rjrjr wrote:
assert ! PotentialElement.is(parent) : "Cannot append to a
PotentialElement";
Done.
http://gwt-code-reviews.appspot.com/1450810/diff/3008/user/src/com/google/gwt/user/client/ui/PotentialElement.java
File user/src/com/google/gwt/user/client/ui/PotentialElement.java
(right):
http://gwt-code-reviews.appspot.com/1450810/diff/3008/user/src/com/google/gwt/user/client/ui/PotentialElement.java#newcode21
user/src/com/google/gwt/user/client/ui/PotentialElement.java:21: /**
On 2011/06/02 17:12:30, rjrjr wrote:
* EXPERIMENTAL and subject to change. Do not use this in production
code.
* <p>
Done.
http://gwt-code-reviews.appspot.com/1450810/diff/3008/user/src/com/google/gwt/user/client/ui/UIObject.java
File user/src/com/google/gwt/user/client/ui/UIObject.java (right):
http://gwt-code-reviews.appspot.com/1450810/diff/3008/user/src/com/google/gwt/user/client/ui/UIObject.java#newcode808
user/src/com/google/gwt/user/client/ui/UIObject.java:808: /**
On 2011/06/02 17:12:30, rjrjr wrote:
I'd still like this to be inlined.
Done.
http://gwt-code-reviews.appspot.com/1450810/diff/3008/user/src/com/google/gwt/user/client/ui/UIObject.java#newcode895
user/src/com/google/gwt/user/client/ui/UIObject.java:895: protected
Element finishBuild() {
On 2011/06/02 17:12:30, rjrjr wrote:
How about we rename this method resolvePotentialElement.
/**
* EXPERIMENTAL and subject to change. Do not use this in production
code.
* <p>
* To be overridden by {@link IsRenderable} subclasses that initialize
themselves by by calling
* <code>setElement(PotentialElement.build(this))</code>.
* <p>
* The receiver must:
* <ul>
* <li> create a real {@link Element} to replace its {@link
PotentialElement}
* <li> call {@link #setElement()} with the new Element
* <li> and return the new Element
* </ul>
* <p>
* This method is called when the receiver's element is about to be
* added to a parent node, as a side effect of {@link
DOM#appendChild}.
* <p>
* Note that this method is normally called only on the top element
* of an IsRenderable tree. Children instead will receive {@link
* IsRenderable#render} and {@link IsRenderable#wrap}.
*
* @see PotentialElement
* @see IsRenderable
*/
Done.
http://gwt-code-reviews.appspot.com/1450810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
