I think we're there, just a couple of nits.

http://gwt-code-reviews.appspot.com/1450810/diff/6006/user/src/com/google/gwt/user/client/DOM.java
File user/src/com/google/gwt/user/client/DOM.java (right):

http://gwt-code-reviews.appspot.com/1450810/diff/6006/user/src/com/google/gwt/user/client/DOM.java#newcode58
user/src/com/google/gwt/user/client/DOM.java:58: * {@link Element} is
added instead.
That method is private now. How about:

If the child element is a {@link PotentialElement} it is first resolved.

@see PotentialElement#resolve(Element)

http://gwt-code-reviews.appspot.com/1450810/diff/6006/user/src/com/google/gwt/user/client/ui/PotentialElement.java
File user/src/com/google/gwt/user/client/ui/PotentialElement.java
(right):

http://gwt-code-reviews.appspot.com/1450810/diff/6006/user/src/com/google/gwt/user/client/ui/PotentialElement.java#newcode87
user/src/com/google/gwt/user/client/ui/PotentialElement.java:87: assert
Element.is(maybePotential);
I don't think you need the assert here. Any smart caller will have used
Element.as() themselves.

http://gwt-code-reviews.appspot.com/1450810/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to