[gwt-contrib] Re: Making media events bitless, freeing up a few event bits, since modern, (issue1447816)

[fredsa]

Yep and yep. Thanks.


http://gwt-code-reviews.appspot.com/1447816/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
(right):

http://gwt-code-reviews.appspot.com/1447816/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java#newcode223
user/src/com/google/gwt/user/client/impl/DOMImplStandard.java:223: if
(eventTypeName == "drag")
On 2011/06/03 17:10:39, jlabanca wrote:

Does javascript allow switch statements with strings?  If so, we might

want to

use a switch statement instead of else if checks.

Done.

http://gwt-code-reviews.appspot.com/1447816/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java#newcode240
user/src/com/google/gwt/user/client/impl/DOMImplStandard.java:240:
elem.onprogress  =
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchEvent;
On 2011/06/03 17:10:39, jlabanca wrote:

Are we missing canplaythrough?

Done.

http://gwt-code-reviews.appspot.com/1447816/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors