LGTM

http://gwt-code-reviews.appspot.com/1447816/diff/2002/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
(right):

http://gwt-code-reviews.appspot.com/1447816/diff/2002/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java#newcode248
user/src/com/google/gwt/user/client/impl/DOMImplStandard.java:248: //
re-entrant safe
Can you expand this comment to say:
"These events are re-entrant safe because they are only available on
modern browsers that do not leak memory."

http://gwt-code-reviews.appspot.com/1447816/diff/2002/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java#newcode254
user/src/com/google/gwt/user/client/impl/DOMImplStandard.java:254: throw
eventTypeName;
change to:

throw "Trying to sink unknown event type " + eventTypeName;

http://gwt-code-reviews.appspot.com/1447816/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to