Can you describe the motivation for the changes to the *.gwt.xml files?


http://gwt-code-reviews.appspot.com/1448808/diff/6001/dev/core/src/com/google/gwt/dev/CompileModule.java
File dev/core/src/com/google/gwt/dev/CompileModule.java (right):

http://gwt-code-reviews.appspot.com/1448808/diff/6001/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode54
dev/core/src/com/google/gwt/dev/CompileModule.java:54: *
Makes sense to post-pone.  Add a TODO?
Seems it would be nice to clean up the inherted module inconsistencies
too (e.g. add User to Logging's inherits). Can we add warnings somehow
wherever undeclared dependencies exist?  I wasn't aware that there could
be circular inheritences, is that a requirement, a loophole, or a
feature?

http://gwt-code-reviews.appspot.com/1448808/diff/6001/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java
File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right):

http://gwt-code-reviews.appspot.com/1448808/diff/6001/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java#newcode94
dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:94: private final
Set<URL> archiveURLs = new LinkedHashSet<URL>();
You could probably store Strings, that represent the URL's (from which
you can construct a new URL, etc.).  But I think that's probably
overkill.

http://gwt-code-reviews.appspot.com/1448808/diff/7007/dev/core/src/com/google/gwt/dev/CompileModule.java
File dev/core/src/com/google/gwt/dev/CompileModule.java (right):

http://gwt-code-reviews.appspot.com/1448808/diff/7007/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode190
dev/core/src/com/google/gwt/dev/CompileModule.java:190:
maybe move this TODO (or duplicate it) at the bottom of the class level
javadoc, where you describe the order dependency.

http://gwt-code-reviews.appspot.com/1448808/diff/7007/dev/core/src/com/google/gwt/dev/Precompile.java
File dev/core/src/com/google/gwt/dev/Precompile.java (right):

http://gwt-code-reviews.appspot.com/1448808/diff/7007/dev/core/src/com/google/gwt/dev/Precompile.java#newcode400
dev/core/src/com/google/gwt/dev/Precompile.java:400: /**
.gwtar

http://gwt-code-reviews.appspot.com/1448808/diff/7007/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java
File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right):

http://gwt-code-reviews.appspot.com/1448808/diff/7007/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java#newcode95
dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:95: /**
.gwtar

http://gwt-code-reviews.appspot.com/1448808/diff/7007/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java#newcode221
dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:221: * Free up memory
no longer needed in later compile stages. After calling this
s/ResourceOraclewill/ResourceOracle will/

http://gwt-code-reviews.appspot.com/1448808/diff/7007/user/build.xml
File user/build.xml (right):

http://gwt-code-reviews.appspot.com/1448808/diff/7007/user/build.xml#newcode1
user/build.xml:1: <project name="user" default="build" basedir=".">
hard to see changes here due to reformat jitter

http://gwt-code-reviews.appspot.com/1448808/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to